Closed
Conversation
evanlucas
approved these changes
Nov 29, 2016
princejwesley
approved these changes
Nov 29, 2016
targos
approved these changes
Nov 29, 2016
Member
Author
lpinca
previously approved these changes
Nov 30, 2016
Member
|
Hmm failures seem related. |
lpinca
reviewed
Nov 30, 2016
test/parallel/test-debug-args.js
Outdated
Member
There was a problem hiding this comment.
The ! should be removed as the original check was process.execArgv.indexOf('--debug-code') != -1.
Member
Author
There was a problem hiding this comment.
Well, that's certainly embarrassing. I must have tried to do a shortcut by only running the test I changed, and then pasted in the wrong file name or something. Fixing momentarily.
* indexOf() -> includes() * var -> const
Member
Author
|
Fixed. Let's try again. CI: https://ci.nodejs.org/job/node-test-pull-request/5032/ |
lpinca
approved these changes
Nov 30, 2016
cjihrig
approved these changes
Dec 1, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 2, 2016
* indexOf() -> includes() * var -> const PR-URL: nodejs#9833 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in cf2562b |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
* indexOf() -> includes() * var -> const PR-URL: #9833 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
* indexOf() -> includes() * var -> const PR-URL: nodejs#9833 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
* indexOf() -> includes() * var -> const PR-URL: nodejs#9833 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* indexOf() -> includes() * var -> const PR-URL: #9833 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test debugger
Description of change